Change type from 'any' in onValuesChange's changedValues #760

John-Feola · 2025-07-16T17:20:42Z

Changes onValueChange's changedValues type to Partial<Values> from any

Summary by CodeRabbit

类型更新
- 优化了回调函数 onValuesChange 的参数类型，提升了类型提示和开发体验。

vercel · 2025-07-16T17:20:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
field-form	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 5:21pm

coderabbitai · 2025-07-16T17:20:48Z

Walkthrough

本次变更将 Callbacks 接口中 onValuesChange 回调的第一个参数类型由 any 修改为 Partial<Values>，更准确地表达了 changedValues 仅为 Values 部分属性的对象。其他接口声明未发生变化。

Changes

文件	变更摘要
src/interface.ts	更新 `Callbacks` 接口中 `onValuesChange` 回调的参数类型，将 `changedValues` 从 `any` 改为 `Partial<Values>`

Poem

兔子挥笔改类型，
any 变身更具体。
部分属性更清晰，
类型安全更贴心。
代码世界添新意，
跳跃前行无所惧！

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/interface.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0abb904 and 8905e7d.

📒 Files selected for processing (1)

src/interface.ts (1 hunks)

🔇 Additional comments (1)

src/interface.ts (1)

207-207: 优秀的类型安全改进！

将 changedValues 参数的类型从 any 改为 Partial<Values> 是一个很好的改进：

提供了更精确的类型定义，changedValues 只包含已更改字段的子集

消除了 any 类型的使用，提高了类型安全性

向后兼容，因为 Partial<Values> 比 any 更加严格

为使用者提供更好的 IDE 智能提示和类型检查

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-07-17T01:14:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (0abb904) to head (8905e7d).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          19       19           
  Lines        1287     1287           
  Branches      300      319   +19     
=======================================
  Hits         1281     1281           
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

li-jia-nan · 2025-09-24T15:13:37Z

这个是 breaking change

li-jia-nan · 2025-09-24T15:24:42Z

demo: fix type error ant-design/ant-design#55138

fix type for onValuesChange changedValues

8905e7d

vercel bot deployed to Preview July 16, 2025 17:21 View deployment

yoyo837 approved these changes Jul 17, 2025

View reviewed changes

yoyo837 merged commit 2b0f66b into react-component:master Jul 17, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Change type from 'any' in onValuesChange's changedValues #760

Change type from 'any' in onValuesChange's changedValues #760

Uh oh!

John-Feola commented Jul 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 16, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Jul 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

li-jia-nan commented Sep 24, 2025

Uh oh!

li-jia-nan commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

Change type from 'any' in onValuesChange's changedValues #760

Change type from 'any' in onValuesChange's changedValues #760

Uh oh!

Conversation

John-Feola commented Jul 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

li-jia-nan commented Sep 24, 2025

Uh oh!

li-jia-nan commented Sep 24, 2025

Uh oh!

Uh oh!

John-Feola commented Jul 16, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 16, 2025 •

edited

Loading

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jul 17, 2025 •

edited

Loading